fix: avoid deprecated usage of vim.validate#3096
Closed
carlosala wants to merge 1 commit intonvim-tree:masterfrom
carlosala:cs-deprecated
Closed
fix: avoid deprecated usage of vim.validate#3096carlosala wants to merge 1 commit intonvim-tree:masterfrom carlosala:cs-deprecated
vim.validate#3096carlosala wants to merge 1 commit intonvim-tree:masterfrom
carlosala:cs-deprecated
Conversation
alex-courtis
requested changes
Apr 4, 2025
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Many thanks for finding and fixing this. We would need to provide a backwards compatible shim for the minimum supported nvim version 0.9.
However, I reckon we should just remove this validate completely:
- This one and only one use was from a time when we were heavily experimenting with legacy options and we didn't have LSP / type checking / CI.
- We have proper luadoc type annotations now
Author
|
Sounds good. Yeah, I didn't know it wasn't available on older versions 👍🏻 |
|
What about adding an nvim-version check? I.e. something like this local safe_validate = function(arr)
if vim.fn.has("nvim-0.9") == 1 then
for key, args in pairs(arr) do
vim.validate(key, unpack(args))
end
else
vim.validate(arr)
end
end
local ok, err = pcall(safe_validate, {
src = { src, "table" },
-- rest |
Member
Sorry, I mean just delete this whole check block that's not needed: |
Author
|
Hey! Closing then, since it can be removed. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vim.validatein its spec form is deprecated.This fixes it.